[PATCH] Test-suite McCat signed char

Renato Golin renato.golin at linaro.org
Tue Mar 5 01:43:57 PST 2013


Updated, as a comment.

--renato


On 5 March 2013 17:37, Renato Golin <renato.golin at linaro.org> wrote:

> On 5 March 2013 17:28, Kristof Beyls <kristof.beyls at arm.com> wrote:
>
>> might be better written as just an unconditional “typedef signed char
>> char_t” for all architectures.
>>
>> Maybe a one-line comment would be useful to state that the test relies on
>> chars being signed, and that chars are not signed by default on all
>> architectures?
>>
>
> That's also an option.
>
>
> ****
>>
>> By dropping the “ifdef __arm__” part, the test would also be fixed on any
>> other architectures on which chars are unsigned by default.
>>
>
> Are there any others? ;)
>
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130305/c2a05908/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mccat-2.patch
Type: application/octet-stream
Size: 5633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130305/c2a05908/attachment.obj>


More information about the llvm-commits mailing list