PATCH: DAGCombiner - Use correct value type when checking legality of BR_CC - Changes to NVPTX, Mips, Hexagon, MBlaze, X86, and XCore targets

Tom Stellard tom at stellard.net
Mon Mar 4 14:36:00 PST 2013


Hi,

Here is an updated patches with the requested fixes for Hexagon, Mips,
and XCore targets.

-Tom

On Mon, Mar 04, 2013 at 09:03:25AM +0000, Richard Osborne wrote:
> Hi Tom,
> 
> For XCore the you only need to expand i32 - f32 isn't a legal type so setting expand on it isn't necessary.
> 
> On 27 Feb 2013, at 23:14, Tom Stellard <tom at stellard.net> wrote:
> 
> > Here is an updated patch.  The previous version had some unrelated
> > changes included in it.
> > 
> > -Tom
> > 
> > On Wed, Feb 27, 2013 at 05:21:59PM -0500, Tom Stellard wrote:
> >> Forgot the patch...
> >> 
> >> On Wed, Feb 27, 2013 at 05:17:32PM -0500, Tom Stellard wrote:
> >>> Hi,
> >>> 
> >>> The attached patch fixes a bug where the DAGCombiner was passing the
> >>> MVT::Other value type to TLI.isOperationLegalOrCustom() for a BR_CC node.
> >>> LegalizeDAG uses the value type of the comparison operands, and I think
> >>> this is what the DAGCombiner should be using as well.
> >>> 
> >>> I've updated the *ISelLowering files for the affected targets, but
> >>> backend code owners should double check my work.
> >>> 
> >>> Thanks,
> >>> Tom
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at cs.uiuc.edu
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > 
> > <0001-DAGCombiner-Use-correct-value-type-for-checking-lega.patch>_______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-DAGCombiner-Use-correct-value-type-for-checking-lega.patch
Type: text/x-diff
Size: 7500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130304/fd6a3c77/attachment.patch>


More information about the llvm-commits mailing list