[LLVMdev] GCMetadataPrinter::finishAssembly not executed?

Yiannis Tsiouris gtsiour at softlab.ntua.gr
Fri Mar 1 03:14:00 PST 2013


Hi Dmitry (et al.),

Ping.

On 02/27/2013 06:05 PM, Yiannis Tsiouris wrote:
> On 02/27/2013 05:53 PM, Dmitry Babokin wrote:
>> -    /// clear - Resets the pass. The metadata deleter pass calls this.
>> +    /// clear - Resets the pass. The metadata printer pass calls this.
>>
>> I would propose different text here:
>> /// clear - Resets the pass. Any pass, which uses GCModuleInfo(), 
>> should call it in doFinalization().
>>
>> Does it make sense?
> Yeap, totally! :-)
>
> Thanks! Re-attaching for conveniency.
Should I commit this (now that I have commit access :D) or there is any 
objection to it?

yiannis

-- 
Yiannis Tsiouris
Ph.D. student,
Software Engineering Laboratory,
National Technical University of Athens
WWW: http://www.softlab.ntua.gr/~gtsiour

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcinfodeleter-cleanup-v2.patch
Type: text/x-patch
Size: 1572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130301/47e7d4d2/attachment.bin>


More information about the llvm-commits mailing list