[llvm] r176214 - The FastISEL should be fast. But when we record statistics we use atomic operations to increment the counters.

Eli Bendersky eliben at google.com
Thu Feb 28 09:19:23 PST 2013


>> I kept NumDAGBlocks and NumFastIselBlocks, because they are called once
>> per blocks and not once per instructions. I don't mind if we put them behind
>> #ifndef NDEBUG as well.
>
>
> It's why I was asking, I think it might be an interesting idea to put all
> the statistics
> behind NDEBUG so we can feel free to collect stats whenever rather than
> needing to worry about putting the high firing status under NDEBUG
> explicitly.

FWIW, I'm +1 on this. You'll still have to wrap the actual ++counter
code with DEBUG or some other macro-fu all over the code, though.

Eil



More information about the llvm-commits mailing list