[PATCH] [lld] Add basic linker script parsing.

Dmitri Gribenko gribozavr at gmail.com
Thu Feb 28 04:58:18 PST 2013



================
Comment at: lib/ReaderWriter/LinkerScript.cpp:95-96
@@ +94,4 @@
+    case '\r':
+    case '\n':
+    case '\t':
+      _buffer = _buffer.drop_front();
----------------
Also '\v', '\f'?

================
Comment at: lib/ReaderWriter/LinkerScript.cpp:160
@@ +159,3 @@
+OutputFormat *Parser::parseOutputFormat() {
+  // Eat OUTPUT_FORMAT
+  consumeToken();
----------------
It is better to turn this comment into an assert().  Same in functions below.


http://llvm-reviews.chandlerc.com/D477



More information about the llvm-commits mailing list