[PATCH] StopTheWorld in sanitizer_common (first commit)

Alexey Samsonov samsonov at google.com
Wed Feb 27 05:26:59 PST 2013



================
Comment at: lib/sanitizer_common/tests/sanitizer_stoptheworld_test.cc:85
@@ +84,3 @@
+  // terminate before we can return from this function.
+  int join_status = pthread_join(thread_id, NULL);
+  ASSERT_EQ(join_status, 0);
----------------
Kostya Serebryany wrote:
> EXPECT_EQ(thread_join(thread_id, NULL), 0)
EXPECT_EQ(0, pthread_join(thread_id, NULL))
Generally the first arg of EXPECT_EQ is the expected value.


http://llvm-reviews.chandlerc.com/D469



More information about the llvm-commits mailing list