[PATCH] [lld][ELF][Writer] Add dynamic relocation tables.
Shankar Kalpathi Easwaran
shankarke at gmail.com
Tue Feb 26 15:32:40 PST 2013
Other than that only comment, changes LGTM
================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:32-38
@@ -31,1 +31,9 @@
+namespace {
+LLVM_ATTRIBUTE_UNUSED std::string kindOrUnknown(llvm::ErrorOr<std::string> k) {
+ if (k)
+ return *k;
+ return "<unknown>";
+}
+}
+
----------------
Could this be in RelocationHelperFunctions or ErrorOr ?
http://llvm-reviews.chandlerc.com/D461
More information about the llvm-commits
mailing list