[llvm] r176120 - Debug Info: for static member variables, move AT_MIPS_linkage_name from

[Manman Ren]

On Feb 26, 2013, at 12:57 PM, Eric Christopher <echristo at gmail.com> wrote:

> 
> 
> 
> On Tue, Feb 26, 2013 at 12:48 PM, Manman Ren <mren at apple.com> wrote:
> Author: mren
> Date: Tue Feb 26 14:48:29 2013
> New Revision: 176120
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=176120&view=rev
> Log:
> Debug Info: for static member variables, move AT_MIPS_linkage_name from
> TAG_member inside a class to the specification DIE.
> 
> Having AT_MIPS_linkage_name on TAG_member caused old gdb (GNU 6.3.50) to
> error out. Also gcc 4.7 has AT_MIPS_linkage_name on the specification DIE.
> 
> If this is for compatibility only then it should be under a flag. It sounds like this is just
> for correctness though and so the comment should reflect this.
Hi Eric,

This is a correctness issue, it caused GNU gdb 6.3.50 to error out.
> 
> Have you looked at other usages of AT_MIPS_linkage name and what's expected?
I didn't go though all usages of AT_MIPS_linkage, but apparently this is causing debuginfo_test to fail:
http://smooshlab.apple.com:8013/builders/clang-x86_64-darwin10-nobootstrap-RA/builds/2397

I am looking at the failure and reverted the patch in the meantime.

Thanks,
Manman
> 
> -eric 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130226/16dc6441/attachment.html>