[PATCH] [fast-isel] x86_64 FastLowerArguments

[Eric Christopher]

+  if (!Subtarget->is64Bit())
+    return false;

Can you put a comment over this or perhaps even a block comment over the
function that it's only valid for 32-bit abis? I totally missed that the
first time through and had a question about "hey, doesn't this fail
horribly for x86-32? :)

Want to add more testcases? Specifically ones that look at the output and
that we got the right arg into the right register... or at least used the
correct registers. :)

-eric


On Fri, Feb 22, 2013 at 3:34 PM, Chad Rosier <mcrosier at apple.com> wrote:

> All,
> The attached patch implements a basic version of FastLowerArguments for
> x86 fast-isel.  This is analogous to Evan's commit r174855, but for x86 of
> course.  Please have a look (especially those familiar with x86 calling
> conventions).
>
>  Regards,
>   Chad
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130226/9be27b77/attachment.html>