[PATCH 1/9] R600/SI: fix stupid typo
Tom Stellard
tom at stellard.net
Mon Feb 25 18:10:58 PST 2013
Hi Christian,
For patch 2, I think there might be an additional cleanup we can do.
I have some questions on patches 3 and 5, and it would be helpful
if you could answer them with comments in the code. With those
changes, the series looks good, and is:
Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
-Tom
On Mon, Feb 25, 2013 at 03:48:56PM +0100, Christian König wrote:
> From: Christian König <christian.koenig at amd.com>
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
> lib/Target/R600/MCTargetDesc/SIMCCodeEmitter.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Target/R600/MCTargetDesc/SIMCCodeEmitter.cpp b/lib/Target/R600/MCTargetDesc/SIMCCodeEmitter.cpp
> index 2bf8fb8..6cc0077 100644
> --- a/lib/Target/R600/MCTargetDesc/SIMCCodeEmitter.cpp
> +++ b/lib/Target/R600/MCTargetDesc/SIMCCodeEmitter.cpp
> @@ -131,7 +131,7 @@ uint32_t SIMCCodeEmitter::getLitEncoding(const MCOperand &MO) const {
> if (Imm.F == 4.0f)
> return 246;
>
> - if (Imm.F == 4.0f)
> + if (Imm.F == -4.0f)
> return 247;
>
> return 255;
> --
> 1.7.10.4
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list