[dragonegg] r176016 - Format with clang-format.

[Tobias Grosser]

On 02/25/2013 11:54 AM, Duncan Sands wrote:
> Author: baldrick
> Date: Mon Feb 25 04:54:25 2013
> New Revision: 176016
>
> URL: http://llvm.org/viewvc/llvm-project?rev=176016&view=rev
> Log:
> Format with clang-format.
> @@ -568,14 +568,14 @@ private:
>   #endif
>     Value *EmitReg_VEC_PACK_FIX_TRUNC_EXPR(tree_node *type, tree_node *op0,
>                                            tree_node *op1);
> -  Value *EmitReg_VEC_PACK_TRUNC_EXPR(tree_node *type, tree_node *op0,
> -                                     tree_node *op1);
> +  Value *
> +  EmitReg_VEC_PACK_TRUNC_EXPR(tree_node *type, tree_node *op0, tree_node *op1);
>     Value *EmitReg_VEC_WIDEN_MULT_HI_EXPR(tree_node *type, tree_node *op0,
>                                           tree_node *op1);
>     Value *EmitReg_VEC_WIDEN_MULT_LO_EXPR(tree_node *type, tree_node *op0,
>                                           tree_node *op1);
> -  Value *EmitReg_WIDEN_MULT_EXPR(tree_node *type, tree_node *op0,
> -                                 tree_node *op1);
> +  Value *
> +  EmitReg_WIDEN_MULT_EXPR(tree_node *type, tree_node *op0, tree_node *op1);

This is something that I think is not ideal. Most code in LLVM either 
puts all return values on a new line or all return values on the name of 
the function definition. The mix that clang-format produces here seems 
hard to read. Making this configurable and choosing one fixed behavior 
for LLVM could make this more consistent.

Cheers,
Tobias