[PATCH] Simplify the logic in getX86SubSuperRegister

[Eli Bendersky]

Thanks, r175672.


On Wed, Feb 20, 2013 at 2:54 PM, Nadav Rotem <nrotem at apple.com> wrote:
> LGTM.
>
> On Feb 20, 2013, at 2:48 PM, Eli Bendersky <eliben at google.com> wrote:
>
>> Ping
>>
>> On Fri, Feb 15, 2013 at 2:02 PM, Eli Bendersky <eliben at google.com> wrote:
>>> Hello,
>>>
>>> getX86SubSuperRegister has a special mode with High=true for i64 which
>>> exists solely to enable it to call itself for i8 with some registers.
>>> The proposed patch simplifies the function somewhat to make the High
>>> bit only meaningful for the i8 mode, which makes sense. No functional
>>> difference (getX86SubSuperRegister is not getting called from anywhere
>>> outside with i64 and High=true).
>>>
>>> If this looks OK, I'll also add a comment that documents
>>> getX86SubSuperRegister propertly.
>>>
>>> Eli
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>