[PATCH] Fix PR15267

[Hal Finkel]

----- Original Message -----
> From: "Duncan Sands" <baldrick at free.fr>
> To: "Nadav Rotem" <nrotem at apple.com>
> Cc: llvm-commits at cs.uiuc.edu
> Sent: Wednesday, February 20, 2013 11:23:33 AM
> Subject: Re: [PATCH] Fix PR15267
> 
> Hi Nadav,
> 
> On 20/02/13 17:53, Nadav Rotem wrote:
> >
> > On Feb 20, 2013, at 2:35 AM, Duncan Sands <baldrick at free.fr
> > <mailto:baldrick at free.fr>> wrote:
> >
> >> it sounds like you consider <4 x i1> to be bitpacked in memory,
> >> like i4.
> >> Is that right?
> >
> > Yes. We need this in order to be consistent with targets that
> > support mask
> > registers.
> 
> while it makes sense to me, can you please document this somewhere
> and ensure
> that getTypeAllocSize and friends are fixed (should return 1 byte!).

Also, we need to make sure that global constants are emitted correctly. Currently, if you make a <N x i1> global constant, it will emit each element into a separate byte.

 -Hal

> 
> Ciao, Duncan.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>