[PATCH] [lld][ELF][Writer] Add dynamic table.

Shankar Kalpathi Easwaran shankarke at gmail.com
Wed Feb 20 05:30:12 PST 2013


  Other than that comment, LGTM.


================
Comment at: lib/ReaderWriter/ELF/HeaderChunks.h:186
@@ -186,1 +185,3 @@
+    if (segment->segmentType() == llvm::ELF::PT_TLS ||
+        segment->segmentType() == llvm::ELF::PT_DYNAMIC) {
       auto phdr = allocateProgramHeader();
----------------
PT_DYNAMIC is not being set anywhere in the diff ?


http://llvm-reviews.chandlerc.com/D427



More information about the llvm-commits mailing list