[llvm] r175394 - Make the visibility of LLVMPPCCompilationCallback work with GCC.

[Rafael Espíndola]

Thank you! I will report a bug about it.

On 17 February 2013 09:30, Benjamin Kramer <benny.kra at googlemail.com> wrote:
> Author: d0k
> Date: Sun Feb 17 08:30:32 2013
> New Revision: 175394
>
> URL: http://llvm.org/viewvc/llvm-project?rev=175394&view=rev
> Log:
> Make the visibility of LLVMPPCCompilationCallback work with GCC.
>
> GCC warns about the attribute being ignored if it occurs after void*.
> There seems to be some kind of incompatibility between clang and gcc here, but
> I can't fathom who's right.
>
> void* LLVM_LIBRARY_VISIBILITY foo(); // clang: hidden, gcc: default
> LLVM_LIBRARY_VISIBILITY void *bar(); // clang: hidden, gcc: hidden
> void LLVM_LIBRARY_VISIBILITY qux();  // clang: hidden, gcc: hidden
>
> Modified:
>     llvm/trunk/lib/Target/PowerPC/PPCJITInfo.cpp
>
> Modified: llvm/trunk/lib/Target/PowerPC/PPCJITInfo.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCJITInfo.cpp?rev=175394&r1=175393&r2=175394&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/PowerPC/PPCJITInfo.cpp (original)
> +++ llvm/trunk/lib/Target/PowerPC/PPCJITInfo.cpp Sun Feb 17 08:30:32 2013
> @@ -292,7 +292,7 @@ void PPC64CompilationCallback() {
>  #endif
>
>  extern "C" {
> -void* LLVM_LIBRARY_VISIBILITY
> +LLVM_LIBRARY_VISIBILITY void *
>  LLVMPPCCompilationCallback(unsigned *StubCallAddrPlus4,
>                             unsigned *OrigCallAddrPlus4,
>                             bool is64Bit) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits