[llvm] r175370 - Turn the enum attributes DenseSet in AttrBuilder into a set of bits.

[Bill Wendling]

On Feb 18, 2013, at 4:33 AM, Benjamin Kramer <benny.kra at gmail.com> wrote:

> 
> On 18.02.2013, at 07:49, Bill Wendling <wendling at apple.com> wrote:
> 
>> On Feb 17, 2013, at 4:09 AM, Benjamin Kramer <benny.kra at gmail.com> wrote:
>> 
>>> On 17.02.2013, at 11:46, Bill Wendling <wendling at apple.com> wrote:
>>> 
>>>> Holy cow...could you have told me first before you went and did this?! I've kinda been working on this a lot, and would have liked to review your changes first. :-(
>>> 
>>> I would've asked you for review on major changes, but this is just a minor implementation detail. DenseSet is really not the right data structure to store a set of 34 enums and I fixed that. And yes, I should've seen that when you first committed the enum DenseMapInfo stuff.
>>> 
>>> If you have problems with this commit I'm sure they can be fixed. Working on a public tree yields merge conflicts from time to time, sorry for any extra work created by that.
>>> 
>> I echo Chandler's comment that we shouldn't be restricted to 64-bits.
> 
> OK, I discussed this with Chandler and decided that this was rather low priority. Fixed in r175437 now.
> 
Thanks.

>> It's not so much the extra work, but when someone is actively working on a piece of software, I would say it's a courtesy to consult with them first. You didn't do anything wrong in terms of working on the LLVM public tree of course, but I would have appreciated a heads up at least.
> 
> I'll try to poke you before I commit a larger change in this area next time.

Thank you. I appreciate it. :)

-bw