[llvm] r175370 - Turn the enum attributes DenseSet in AttrBuilder into a set of bits.

Benjamin Kramer benny.kra at gmail.com
Sat Feb 16 14:29:56 PST 2013


On 16.02.2013, at 23:24, Chandler Carruth <chandlerc at google.com> wrote:

> 
> On Sat, Feb 16, 2013 at 11:13 AM, Benjamin Kramer <benny.kra at googlemail.com> wrote:
> Author: d0k
> Date: Sat Feb 16 13:13:18 2013
> New Revision: 175370
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=175370&view=rev
> Log:
> Turn the enum attributes DenseSet in AttrBuilder into a set of bits.
> 
> Avoids malloc and is a lot denser. We lose iteration over target independent
> attributes, but that's a strange interface anyways and didn't have any users
> outside of AttrBuilder.
> 
> One of the goals was to remove the arbitrary upper limit of 64 -- could you maybe use a BitVector so that we don't hit this later?

Sure, I can use a std::bitset. There are currently 34 attrs so I thought this wasn't necessary.

- Ben



More information about the llvm-commits mailing list