[llvm] r175342 - Use a different scheme to chose 16/32 variants. This scheme is more

[Reed Kotler]

Author: rkotler
Date: Sat Feb 16 03:47:57 2013
New Revision: 175342

URL: http://llvm.org/viewvc/llvm-project?rev=175342&view=rev
Log:
Use a different scheme to chose 16/32 variants. This scheme is more
consistent with how BuildMI works. No new tests needed. All should work
the same as before.


Modified:
    llvm/trunk/lib/Target/Mips/Mips16InstrInfo.cpp
    llvm/trunk/lib/Target/Mips/Mips16InstrInfo.h

Modified: llvm/trunk/lib/Target/Mips/Mips16InstrInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/Mips16InstrInfo.cpp?rev=175342&r1=175341&r2=175342&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/Mips16InstrInfo.cpp (original)
+++ llvm/trunk/lib/Target/Mips/Mips16InstrInfo.cpp Sat Feb 16 03:47:57 2013
@@ -184,7 +184,7 @@ void Mips16InstrInfo::makeFrame(unsigned
       int64_t Remainder = FrameSize - Base;
       BuildMI(MBB, I, DL, get(Mips::SaveRaF16)). addImm(Base);
       if (isInt<16>(-Remainder))
-        BuildAddiuSpImm(MBB, I, DL, -Remainder);
+        BuildMI(MBB, I, DL, AddiuSpImm(-Remainder)).addImm(-Remainder);
       else
         adjustStackPtrBig(SP, -Remainder, MBB, I, Mips::V0, Mips::V1);
     }
@@ -225,7 +225,7 @@ void Mips16InstrInfo::restoreFrame(unsig
                        // returns largest possible n bit unsigned integer
       int64_t Remainder = FrameSize - Base;
       if (isInt<16>(Remainder))
-        BuildAddiuSpImm(MBB, I, DL, Remainder);
+        BuildMI(MBB, I, DL,  AddiuSpImm(Remainder)).addImm(Remainder);
       else
         adjustStackPtrBig(SP, Remainder, MBB, I, Mips::A0, Mips::A1);
       BuildMI(MBB, I, DL, get(Mips::RestoreRaF16)). addImm(Base);
@@ -299,7 +299,7 @@ void Mips16InstrInfo::adjustStackPtr(uns
                                      MachineBasicBlock::iterator I) const {
   DebugLoc DL = I != MBB.end() ? I->getDebugLoc() : DebugLoc();
   if (isInt<16>(Amount))  // need to change to addiu sp, ....and isInt<16>
-    BuildAddiuSpImm(MBB, I, DL, Amount);
+    BuildMI(MBB, I, DL, AddiuSpImm(Amount)).addImm(Amount);
   else
     adjustStackPtrBigUnrestricted(SP, Amount, MBB, I);
 }
@@ -400,13 +400,11 @@ void Mips16InstrInfo::ExpandRetRA16(Mach
   BuildMI(MBB, I, I->getDebugLoc(), get(Opc));
 }
 
-void Mips16InstrInfo::BuildAddiuSpImm(
-  MachineBasicBlock &MBB,
-  MachineBasicBlock::iterator II, DebugLoc DL, int64_t Imm) const {
+const MCInstrDesc &Mips16InstrInfo::AddiuSpImm(int64_t Imm) const {
   if (validSpImm8(Imm))
-    BuildMI(MBB, II, DL, get(Mips::AddiuSpImm16)).addImm(Imm);
+    return get(Mips::AddiuSpImm16);
   else
-    BuildMI(MBB, II, DL, get(Mips::AddiuSpImmX16)).addImm(Imm);
+    return get(Mips::AddiuSpImmX16);
 }
 
 const MipsInstrInfo *llvm::createMips16InstrInfo(MipsTargetMachine &TM) {

Modified: llvm/trunk/lib/Target/Mips/Mips16InstrInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/Mips16InstrInfo.h?rev=175342&r1=175341&r2=175342&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/Mips16InstrInfo.h (original)
+++ llvm/trunk/lib/Target/Mips/Mips16InstrInfo.h Sat Feb 16 03:47:57 2013
@@ -93,10 +93,8 @@ public:
   //
   // build the proper one based on the Imm field
   //
-  void BuildAddiuSpImm(MachineBasicBlock &MBB,
-                           MachineBasicBlock::iterator II, DebugLoc DL,
-                           int64_t Imm) const;
 
+  const MCInstrDesc& AddiuSpImm(int64_t Imm) const;
 
 private:
   virtual unsigned GetAnalyzableBrOpc(unsigned Opc) const;