[llvm] r175327 - Derive ELF section type from the name in some cases where GNU as does
Eric Christopher
echristo at gmail.com
Fri Feb 15 17:03:32 PST 2013
On Fri, Feb 15, 2013 at 4:47 PM, Eli Bendersky <eliben at google.com> wrote:
> On Fri, Feb 15, 2013 at 4:44 PM, Eric Christopher <echristo at gmail.com>
> wrote:
> >
> > Comments?
> >
> >>
> >> - if (!TypeName.empty()) {
> >> + if (TypeName.empty()) {
> >
> >
> > Technically don't need the braces here, but honestly in this case I like
> > them :)
> >
>
> Dangling else ambiguity avoidance FTW ;-)
>
>
Aha. Excellent. Some comments would still be good ;)
-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130215/f55bddd3/attachment.html>
More information about the llvm-commits
mailing list