[PATCH] Clarify the pass name of X86AsmPrinter

Jim Grosbach grosbach at apple.com
Fri Feb 15 16:42:51 PST 2013


Seems reasonable to me.

-Jim

On Feb 15, 2013, at 4:41 PM, Eli Bendersky <eliben at google.com> wrote:

> Hello,
> 
> Currently the x86 AsmPrinter reports its name as a hardcoded "X86
> AT&T-Style Assembly Printer". This is somewhat misleading in printouts
> (such as -time-passes and others) when object-file emission is used
> (X86AsmPrinter emits either an object file or assembly via a specific
> MCStreamer).
> 
> This patch replaces this string (and a related comment) with something
> a bit more generic. A more audacious approach would be for the method
> to check which streamer it has and return a precise name. Note also
> that this isn't a x86-specific problem - x86 is just being used as an
> example here. A similar change can be applied to other targets.
> 
> PTAL,
> Eli
> <asmprinter-name.1.patch>




More information about the llvm-commits mailing list