[PATCH] ARM NEON 2-arg vector compare aliases rejected

Jim Grosbach grosbach at apple.com
Thu Feb 14 14:47:37 PST 2013


  OK to commit with the noted minor cleanups.


================
Comment at: lib/Target/ARM/ARMInstrNEON.td:4267
@@ -4266,2 +4266,3 @@
 
+let TwoOperandAliasConstraint = "$Vd = $Vm" in {
 defm VCEQz    : N2V_QHS_cmp<0b11, 0b11, 0b01, 0b00010, 0, "vceq", "i",
----------------
No need for enclosing '{' '}' when there's only one def[m] inside them.

The constraint is typically specified as "$Vm = $Vd" (order reversed).

================
Comment at: test/MC/ARM/neon-bitwise-encoding.s:1
@@ -1,1 +1,2 @@
-@ RUN: llvm-mc -mcpu=cortex-a8 -triple arm-unknown-unknown -show-encoding < %s | FileCheck %s
+@ RUN: llvm-mc -mcpu=cortex-a8 -triple arm-unknown-unknown -show-encoding < %s \
+@ RUN: | FileCheck %s
----------------
Inadvertant change, or 80 column fix? If the latter, no worries, it's just not clear from the diff which it is.


http://llvm-reviews.chandlerc.com/D397



More information about the llvm-commits mailing list