[Patch, TableGen] Fix for bug 15246

[Jyotsna Verma]

Hi Jakob,

Here is a new patch that contains the fix for bug 15246 -- out-of-bound
error in the TableGen backend, CodeGenMapTable.cpp. Please let me know if
it's okay to commit. 

Thanks,
Jyotsna
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


>-----Original Message-----
>From: Eli Bendersky [mailto:eliben at google.com]
>Sent: Wednesday, February 13, 2013 12:54 PM
>To: Jyotsna Verma
>Cc: llvm-commits at cs.uiuc.edu; Jakob Stoklund Olesen
>Subject: Re: [Patch] Fix for bug 15246
>
>On Wed, Feb 13, 2013 at 9:56 AM, Jyotsna Verma <jverma at codeaurora.org>
>wrote:
>>>So if it produces an incorrect enum declaration, can't this be
>>>detected in
>> a
>>>test? Or are you trying to say that the bug is in a specific TG
>>>backend
>> that's not
>>>currently being tested? Would this be difficult to implement?
>>
>> Yes, the bug is specific to a TG backend, CodeGenMapTable.cpp. All the
>> current tests for TableGen appear to be for the frontend/parser. I
>> don't think we have any backend specific test at this point. In order
>> to have such a test, it would require some basic infrastructure in a
>> test .td file, mostly the classes defined in
>> include/llvm/Target/Target.td. This may result into a test with a couple
of
>hundreds of lines.
>
>Or just include the needed .td file(s)?
>
>> I'm not sure if it's
>> desirable just to test a trivial functionality of the backend. It will
>> be more appropriate when used for thorough testing.
>>
>> If it's oaky, I would first like to push the proposed fix for the TG
>> backend (without the Hexagon change). In the meantime, I will see if I
>> can come up with an independent test to validate the fix.
>
>Splitting the patches is a good idea in general. You should get a LGTM from
>someone else, as I'm not the code owner in these parts.
>
>Eli
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130213/952a1c84/attachment.txt>