[PATCH][Review request] add support for ADX instructions (PR15235)

[Kay Tiong Khoo]

Thanks! Updated patch attached. Ok to commit?

On Wed, Feb 13, 2013 at 11:48 AM, Craig Topper <craig.topper at gmail.com>wrote:

> Yes they should all be converted eventually, but that's orthogonal to this
> patch. New code should use hasSideEffects=0.
>
>
> On Wed, Feb 13, 2013 at 10:17 AM, Kay Tiong Khoo <kkhoo at perfwizard.com>wrote:
>
>> Hi Craig -
>> Thank you for the feedback. I see a lot of "neverHasSideEffects = 1" in
>> this file (X86InstrArithmetic.td) for similar instructions including MULX
>> just ahead of where I added ADCX. Should all of these be changed to
>> "hasSideEffects = 0"?
>>
>> utils/TableGen/CodeGenDAGPatterns.cpp has this comment:
>>     // Treat neverHasSideEffects = 1 as the equivalent of hasSideEffects
>> = 0.
>>     // This flag is obsolete and will be removed.
>>
>>
>>
>> On Wed, Feb 13, 2013 at 10:29 AM, Craig Topper <craig.topper at gmail.com>wrote:
>>
>>> Please put hasSideEffects=0 around these since they don't have patterns.
>>>
>>> On Wed, Feb 13, 2013 at 9:19 AM, Kay Tiong Khoo <kkhoo at perfwizard.com>wrote:
>>>
>>>> The latest Intel emulator claims support for these instructions:
>>>>
>>>> http://software.intel.com/en-us/articles/intel-software-development-emulator
>>>>
>>>> But I haven't tried it yet...just wanted the disasm to work first.
>>>>
>>>>
>>>> On Wed, Feb 13, 2013 at 10:12 AM, Eli Bendersky <eliben at google.com>wrote:
>>>>
>>>>> On Wed, Feb 13, 2013 at 9:05 AM, Kay Tiong Khoo <kkhoo at perfwizard.com>
>>>>> wrote:
>>>>> > http://llvm.org/bugs/show_bug.cgi?id=15235
>>>>> >
>>>>> > Please review the attached patch which adds support for Intel's ADX
>>>>> > instructions.
>>>>> >
>>>>> > The patch includes:
>>>>> > 1. Addition of "HasADX" flag.
>>>>> > 2. Definitions for new instructions
>>>>> > 3. Disassembly tests
>>>>> >
>>>>>
>>>>> Do you have hardware (or a simulator?) that actually allows you to run
>>>>> these instructions?
>>>>>
>>>>> Eli
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>>
>>>
>>>
>>> --
>>> ~Craig
>>
>>
>>
>
>
> --
> ~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130213/ff6257de/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: adx.diff
Type: application/octet-stream
Size: 6088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130213/ff6257de/attachment.obj>