[llvm] r175066 - PR14992 - Tablegen incorrectly converts ARM tLDMIA_UPD pseudo to tLDMIA

David Peixotto dpeixott at codeaurora.org
Wed Feb 13 11:21:48 PST 2013


Author: dpeixott
Date: Wed Feb 13 13:21:47 2013
New Revision: 175066

URL: http://llvm.org/viewvc/llvm-project?rev=175066&view=rev
Log:
PR14992 - Tablegen incorrectly converts ARM tLDMIA_UPD pseudo to tLDMIA

Fixed bug in tablegen conversion when source pseudo instruction has
a different number of arguments than the destination instruction.

Added:
    llvm/trunk/test/CodeGen/ARM/2013-01-21-PR14992.ll
Modified:
    llvm/trunk/utils/TableGen/PseudoLoweringEmitter.cpp

Added: llvm/trunk/test/CodeGen/ARM/2013-01-21-PR14992.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2013-01-21-PR14992.ll?rev=175066&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/2013-01-21-PR14992.ll (added)
+++ llvm/trunk/test/CodeGen/ARM/2013-01-21-PR14992.ll Wed Feb 13 13:21:47 2013
@@ -0,0 +1,28 @@
+;PR14492 - Tablegen incorrectly converts ARM tLDMIA_UPD pseudo to tLDMIA
+;RUN: llc -mtriple=thumbv7 < %s  | FileCheck -check-prefix=EXPECTED %s
+;RUN: llc -mtriple=thumbv7 < %s  | FileCheck %s
+
+;EXPECTED: foo:
+;CHECK: foo:
+define i32 @foo(i32* %a) nounwind optsize {
+entry:
+  %0 = load i32* %a, align 4, !tbaa !0
+  %arrayidx1 = getelementptr inbounds i32* %a, i32 1
+  %1 = load i32* %arrayidx1, align 4, !tbaa !0
+  %arrayidx2 = getelementptr inbounds i32* %a, i32 2
+  %2 = load i32* %arrayidx2, align 4, !tbaa !0
+  %add.ptr = getelementptr inbounds i32* %a, i32 3
+;Make sure we do not have a duplicated register in the front of the reg list
+;EXPECTED:  ldm [[BASE:r[0-9]+]]!, {[[REG:r[0-9]+]], {{r[0-9]+}},
+;CHECK-NOT: ldm [[BASE:r[0-9]+]]!, {[[REG:r[0-9]+]], [[REG]],
+  tail call void @bar(i32* %add.ptr) nounwind optsize
+  %add = add nsw i32 %1, %0
+  %add3 = add nsw i32 %add, %2
+  ret i32 %add3
+}
+
+declare void @bar(i32*) optsize
+
+!0 = metadata !{metadata !"int", metadata !1}
+!1 = metadata !{metadata !"omnipotent char", metadata !2}
+!2 = metadata !{metadata !"Simple C/C++ TBAA"}

Modified: llvm/trunk/utils/TableGen/PseudoLoweringEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/PseudoLoweringEmitter.cpp?rev=175066&r1=175065&r2=175066&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/PseudoLoweringEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/PseudoLoweringEmitter.cpp Wed Feb 13 13:21:47 2013
@@ -252,6 +252,7 @@ void PseudoLoweringEmitter::emitLowering
       MIOpNo += Dest.Operands[OpNo].MINumOperands;
     }
     if (Dest.Operands.isVariadic) {
+      MIOpNo = Source.Operands.size() + 1;
       o << "      // variable_ops\n";
       o << "      for (unsigned i = " << MIOpNo
         << ", e = MI->getNumOperands(); i != e; ++i)\n"





More information about the llvm-commits mailing list