[Patch] Fix for bug 15246

Eli Bendersky eliben at google.com
Tue Feb 12 14:53:14 PST 2013


On Tue, Feb 12, 2013 at 2:19 PM, Jyotsna Verma <jverma at codeaurora.org> wrote:
>>From: Eli Bendersky [mailto:eliben at google.com]
>>Sent: Tuesday, February 12, 2013 2:47 PM
>>To: Jyotsna Verma
>>Cc: llvm-commits at cs.uiuc.edu
>>Subject: Re: [Patch] Fix for bug 15246
>>
>>Could you reproduce the problem with Tablegen's tests and then submit two
>>separate patches:
>
> I'm not sure if the problem can be reproduced using a TableGen test.
> TableGen processes the .td file without any error and generates incorrect
> enum declaration in *InstrInfo.inc file.

So if it produces an incorrect enum declaration, can't this be
detected in a test? Or are you trying to say that the bug is in a
specific TG backend that's not currently being tested? Would this be
difficult to implement?

> The problem shows up when we
> compile a .cpp file that includes *InstrInfo.inc. In order to reproduce the
> problem using a TableGen test, I will have to run it with -gen-instr-info
> flag to output this enum declaration.
>



More information about the llvm-commits mailing list