[polly] r174894 - [isl-codegen]: Fix off by one in getNumberOfIterations

Sebastian Pop spop at codeaurora.org
Tue Feb 12 12:03:01 PST 2013


Tobias Grosser wrote:
> dimensions are unnamed, all dimensions are identical. If you remove
> the first or the second, at the end you will have a space with one
> dimension less than the input space.

Ok, thanks for the explanation.

> Yes, please test. I can not imagine any problem, but it's good if
> you test it.

I just started my test and will let you know if I see regressions.

Another point that could be addressed: instead of

    Space = isl_space_drop_outputs(Space, Dim - 1, 1);

you should use the documented ISL function

    Space = isl_space_drop_dims(Space, isl_dim_out, Dim - 1, 1);

Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation



More information about the llvm-commits mailing list