Please review: Fixed a bug in X86 vzeroupper.

Quentin Colombet qcolombet at apple.com
Tue Feb 12 11:34:37 PST 2013


Hi Elena,

The name of the preservesYmmRegs function is confusing because one (at least, I) would expect that it returns true if the operand preserves all Ymm Regs, which is not what the function is doing.

Could you come with a better name please?

Thanks,

-Quentin

On Feb 12, 2013, at 7:04 AM, "Demikhovsky, Elena" <elena.demikhovsky at intel.com> wrote:

> Instruction vzeroupper should not be inserted before call that preserves YMM registers, since a caller uses preserved registers across the call.
> 
> Thanks.
> 
> - Elena
> 
> 
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> <vzeroupper.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130212/b5bcc5bf/attachment.html>


More information about the llvm-commits mailing list