[llvm-commits] Fixing Bug 13662: paired register for inline asm with 64-bit data on ARM

[Weiming Zhao]

Hi Jakob,

 

Sorry, last time,  I forgot to include the test case.

I agree we should reuse most of the logics by moving them to target
independent part. But it needs some hooks to get Target Register info like
ARM::GPRPairRegClass. 

We can refactor the code in the follow-up patch.

 

Thanks,

Weiming

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

From: Jakob Stoklund Olesen [mailto:stoklund at 2pi.dk] 
Sent: Wednesday, February 06, 2013 4:24 PM
To: weimingz at codeaurora.org
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] Fixing Bug 13662: paired register for inline asm
with 64-bit data on ARM

 

 

On Jan 29, 2013, at 3:01 PM, Weiming Zhao <weimingz at codeaurora.org> wrote:





Hi Jakob,

 

Attached is the last piece of the whole patch.

It adds ARM specific support of inline asm of ldrexd/strexd

 

Please help to review it.

 

This basically looks good, but you need multiple test cases.

 

I would prefer to handle this kind of constraint in target independent code,
otherwise the next target will also need to add a big blob of inline asm
special case code. I think it is outside the scope of this patch, though.

 

/jakob

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130212/c0c76b55/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inlineasm-64bit.ll
Type: application/octet-stream
Size: 3519 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130212/c0c76b55/attachment.obj>