[PATCH] add support for merging common strings

[Shankar Kalpathi Easwaran]

================
Comment at: lib/ReaderWriter/ELF/File.h:104
@@ +103,3 @@
+
+  /// \brief find a absolute atom given a name
+  MergeAtomsIter findMergeAtom(uint64_t offset) {
----------------
Michael Spencer wrote:
> Wrong comment.
fixed.

================
Comment at: lib/ReaderWriter/ELF/File.h:232
@@ +231,3 @@
+      unsigned int prev = 0;
+      for (unsigned int i = 0; i < sectionContents.size(); ++i) {
+        if (sectionContents[i] == '\0') {
----------------
Michael Spencer wrote:
>   for (std::size_t i = 0, e = sectionContents.size(); i != e; ++i)
fixed

================
Comment at: lib/ReaderWriter/ELF/File.h:470
@@ +469,3 @@
+                else
+              assert(0 && "unable to find a merge atom");
+          } // find
----------------
Michael Spencer wrote:
> llvm_unreachable.
fixed


http://llvm-reviews.chandlerc.com/D387