[compiler-rt] r174962 - [sanitizer] Missing changes from r174960.

Evgeniy Stepanov eugeni.stepanov at gmail.com
Tue Feb 12 04:47:42 PST 2013


I think adding them to asan_intercepted_functions.h should do the trick.
I don't want to disable them anywhere because we won't be able to do
this exactly when they are unavailable, because we don't control libc.

On Tue, Feb 12, 2013 at 4:14 PM, Alexey Samsonov <samsonov at google.com> wrote:
> Our Mac bots fail because of this as well:
>
> sanitizer_common/sanitizer_common_interceptors.inc:176:25: error: use of
> undeclared identifier '__isoc99_vscanf'; did you mean
> 'wrap___isoc99_vscanf'?
> VSCANF_INTERCEPTOR_IMPL(__isoc99_vscanf, format, ap)
>
> Should we disable these __isoc99_ versions on Mac?
>
>
> On Tue, Feb 12, 2013 at 4:02 PM, Evgeniy Stepanov
> <eugeni.stepanov at gmail.com> wrote:
>>
>> Author: eugenis
>> Date: Tue Feb 12 06:02:49 2013
>> New Revision: 174962
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=174962&view=rev
>> Log:
>> [sanitizer] Missing changes from r174960.
>>
>> Modified:
>>     compiler-rt/trunk/lib/tsan/rtl/tsan_stat.cc
>>     compiler-rt/trunk/lib/tsan/rtl/tsan_stat.h
>>
>> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_stat.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_stat.cc?rev=174962&r1=174961&r2=174962&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/tsan/rtl/tsan_stat.cc (original)
>> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_stat.cc Tue Feb 12 06:02:49 2013
>> @@ -257,6 +257,12 @@ void StatOutput(u64 *stat) {
>>    name[StatInt_scanf]                    = "  scanf
>> ";
>>    name[StatInt_sscanf]                   = "  sscanf
>> ";
>>    name[StatInt_fscanf]                   = "  fscanf
>> ";
>> +  name[StatInt___isoc99_vscanf]          = "  vscanf
>> ";
>> +  name[StatInt___isoc99_vsscanf]         = "  vsscanf
>> ";
>> +  name[StatInt___isoc99_vfscanf]         = "  vfscanf
>> ";
>> +  name[StatInt___isoc99_scanf]           = "  scanf
>> ";
>> +  name[StatInt___isoc99_sscanf]          = "  sscanf
>> ";
>> +  name[StatInt___isoc99_fscanf]          = "  fscanf
>> ";
>>    name[StatInt_on_exit]                  = "  on_exit
>> ";
>>    name[StatInt___cxa_atexit]             = "  __cxa_atexit
>> ";
>>
>>
>> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_stat.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_stat.h?rev=174962&r1=174961&r2=174962&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/tsan/rtl/tsan_stat.h (original)
>> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_stat.h Tue Feb 12 06:02:49 2013
>> @@ -256,6 +256,12 @@ enum StatType {
>>    StatInt_scanf,
>>    StatInt_sscanf,
>>    StatInt_fscanf,
>> +  StatInt___isoc99_vscanf,
>> +  StatInt___isoc99_vsscanf,
>> +  StatInt___isoc99_vfscanf,
>> +  StatInt___isoc99_scanf,
>> +  StatInt___isoc99_sscanf,
>> +  StatInt___isoc99_fscanf,
>>    StatInt_on_exit,
>>    StatInt___cxa_atexit,
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
>
> --
> Alexey Samsonov, MSK



More information about the llvm-commits mailing list