[llvm-commits] [PATCH] PR14992 - Tablegen incorrectly converts ARM tLDMIA_UPD pseudo to tLDMIA

[Bill Wendling]

Hi David,

LGTM. Just a couple of things and then you can check it in:

Please use a target-triple in the 'RUN' line. Something like:

	; RUN: llc < %s -mtriple=thumbv7

That way you can remove the 'target datalayout' and 'target triple' lines.

Also, please do a 'CHECK' for the expected value along with the 'CHECK-NOT'. (If there is no expected value, then what you have is fine....)

-bw

On Feb 11, 2013, at 4:58 PM, David Peixotto <dpeixott at codeaurora.org> wrote:

> Hi Bill,
> 
> I've attached the patch to this email. It is the same patch reviewed by Tim.
> 
> Thanks,
> -David
> 
> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation
> 
> 
> 
>> -----Original Message-----
>> From: Bill Wendling [mailto:bwendling at apple.com]
>> Sent: Monday, February 11, 2013 3:23 PM
>> To: David Peixotto
>> Cc: 'Tim Northover'; 'llvm-commits'
>> Subject: Re: [llvm-commits] [PATCH] PR14992 - Tablegen incorrectly
> converts
>> ARM tLDMIA_UPD pseudo to tLDMIA
>> 
>> Hi David,
>> 
>> Could you reattach the patch please? (I'm missing the previous emails.)
>> 
>> -bw
>> 
>> On Feb 11, 2013, at 11:58 AM, David Peixotto <dpeixott at codeaurora.org>
>> wrote:
>> 
>>> Ping.
>>> 
>>> Is it ok to commit this change? I'm being cautious because tablegen is
>>> a core tool that can impact many targets and I want to make sure the
>>> reviews are sufficient.
>>> 
>>> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>>> hosted by The Linux Foundation
>>> 
>>>> -----Original Message-----
>>>> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
>>>> bounces at cs.uiuc.edu] On Behalf Of David Peixotto
>>>> Sent: Monday, January 28, 2013 9:15 AM
>>>> To: 'Tim Northover'
>>>> Cc: 'llvm-commits'
>>>> Subject: Re: [llvm-commits] [PATCH] PR14992 - Tablegen incorrectly
>>> converts
>>>> ARM tLDMIA_UPD pseudo to tLDMIA
>>>> 
>>>> Ping. Any other feedback/comments about this patch?
>>>> 
>>>> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>>>> hosted by The Linux Foundation
>>>> 
>>>> 
>>>>> -----Original Message-----
>>>>> From: Tim Northover [mailto:t.p.northover at gmail.com]
>>>>> Sent: Tuesday, January 22, 2013 3:08 AM
>>>>> To: David Peixotto
>>>>> Cc: llvm-commits
>>>>> Subject: Re: [llvm-commits] [PATCH] PR14992 - Tablegen incorrectly
>>>> converts
>>>>> ARM tLDMIA_UPD pseudo to tLDMIA
>>>>> 
>>>>>> Thanks for taking a look, Tim. I've attached an updated patch with
>>>>>> the test case from the bug report.
>>>>> 
>>>>> Thanks. Looks good to me.
>>>>> 
>>>>> Tim.
>>>> 
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> <0001-PR14992-Tablegen-incorrectly-converts-ARM-tLDMIA_UPD.PATCH>