[llvm] r174717 - The patch to fix some issues in r174543 fixed the lines failing the test, but missed a couple

[David Tweed]

Hi Tim,
I'd imagine if your DataAlignmentFactor is greater than 2^31 then you've got other fun using llvm....
The types probably ougtht to be changed, but since DWARF dumping isn't on a high-performance path I'm not overly worried about it.

Cheers,
Dave
________________________________________
From: Tim Northover [t.p.northover at gmail.com]
Sent: Friday, February 08, 2013 8:21 PM
To: David Tweed
Cc: llvm-commits
Subject: Re: [llvm] r174717 - The patch to fix some issues in r174543 fixed the lines failing the test, but missed a couple

> The patch to fix some issues in r174543 fixed the lines failing the test, but missed a couple
> of lines which weren't being explicitly looked at and were printing incorrect results. These
> values clearly must lie within 32 bits, so the casts are definitely safe.

Strictly, the fields being printed are LEB128 which is arbitrary
precision. Practically, they may be 32-bit; but if that's a change
we're making it should probably be at the underlying storage level
rather than when dumping.

Unless the formats other than DWARF come into this, of course.

Tim.


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.