[llvm] r174574 - DWARFDebugFrame.cpp: Fix formatting on i686 hosts.

Eli Bendersky eliben at google.com
Wed Feb 6 20:43:45 PST 2013


On Wed, Feb 6, 2013 at 6:02 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Author: chapuni
> Date: Wed Feb  6 20:02:27 2013
> New Revision: 174574
>
> URL: http://llvm.org/viewvc/llvm-project?rev=174574&view=rev
> Log:
> DWARFDebugFrame.cpp: Fix formatting on i686 hosts.
>
> FIXME: Are they really truncated to i32 from i64 unconditionally?
>

Thank you for the fix, Takumi. Semantically it's correct, since we
don't currently support DWARF64 all such values are really 32-bits.

> -    OS << format("%08x %08x %08x CIE", Offset, Length, DW_CIE_ID) << "\n";
> +    OS << format("%08x %08x %08x CIE",
> +                 (uint32_t)Offset, (uint32_t)Length, DW_CIE_ID)
> +       << "\n";



More information about the llvm-commits mailing list