[llvm] r174485 - Failing builds because a private class member is not being used after

Chandler Carruth chandlerc at google.com
Tue Feb 5 22:41:48 PST 2013


On Tue, Feb 5, 2013 at 9:37 PM, Eli Bendersky <eliben at google.com> wrote:

> Author: eliben
> Date: Tue Feb  5 23:37:46 2013
> New Revision: 174485
>
> URL: http://llvm.org/viewvc/llvm-project?rev=174485&view=rev
> Log:
> Failing builds because a private class member is not being used after
> initialization is one of the reasons I consider -werror to be shoddy.
>

This log doesn't really explain the change you made... Did the warning
actually find that your commit didn't include intended code? Just trying to
understand a bit better.


>
> Modified:
>     llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp
>
> Modified: llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp?rev=174485&r1=174484&r2=174485&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp (original)
> +++ llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp Tue Feb  5 23:37:46 2013
> @@ -104,6 +104,9 @@ public:
>                   LinkedCIEOffset, InitialLocation,
>                   InitialLocation + AddressRange);
>      OS << "\n";
> +    if (LinkedCIE) {
> +      OS << format("%p\n", LinkedCIE);
> +    }
>    }
>
>    static bool classof(const FrameEntry *FE) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130205/28e7fe65/attachment.html>


More information about the llvm-commits mailing list