[llvm] r174463 - Initial support for DWARF CFI parsing and dumping in LLVM
Eric Christopher
echristo at gmail.com
Tue Feb 5 15:38:37 PST 2013
Some nitpicking:
+ FrameEntry(FrameKind K, DataExtractor D, uint64_t Offset, uint64_t
> Length)
> + : Kind(K), Data(D), Offset(Offset), Length(Length)
> + {}
> +
>
Probably want to move the {} to the previous line. There are a couple of
places in this file.
> + uint64_t LinkedCIEOffset;
> + uint64_t InitialLocation;
> + uint64_t AddressRange;
> + CIE *LinkedCIE;
>
Some more comments for instance variables.
> +DWARFDebugFrame::DWARFDebugFrame()
> +{
> +}
> +
>
Formatting.
> +
> +DWARFDebugFrame::~DWARFDebugFrame()
> +{
> + for (EntryVector::iterator I = Entries.begin(), E = Entries.end();
> + I != E; ++I) {
> + delete *I;
> + }
> +}
> +
>
Ditto.
> +
> +static void LLVM_ATTRIBUTE_UNUSED dumpDataAux(DataExtractor Data,
> + uint32_t Offset, int
> Length) {
> +
>
Double check this formatting?
> + // TODO: For honest DWARF64 support, DataExtractor will have to treat
> + // offset_ptr as uint64_t*
> + uint32_t EndStructureOffset = Offset + static_cast<uint32_t>(Length);
> +
>
File a bug for this please?
Thanks!
-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130205/2ecb802f/attachment.html>
More information about the llvm-commits
mailing list