[llvm] r174354 - This patch changes a static_cast to dyn_cast

Chandler Carruth chandlerc at google.com
Mon Feb 4 23:52:49 PST 2013


On Mon, Feb 4, 2013 at 11:47 PM, Jack Carter <jcarter at mips.com> wrote:

> Modified: llvm/trunk/include/llvm/MC/MCStreamer.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCStreamer.h?rev=174354&r1=174353&r2=174354&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/MC/MCStreamer.h (original)
> +++ llvm/trunk/include/llvm/MC/MCStreamer.h Tue Feb  5 01:47:41 2013
> @@ -57,6 +57,7 @@ namespace llvm {
>        SK_ARMELFStreamer,
>        SK_MachOStreamer,
>        SK_PureStreamer,
> +      SK_MipsELFStreamer,
>        SK_WinCOFFStreamer
>      };
>

The order really matters here. The MipsELFStreamer is-a ELFStreamer, so it
need sto be in the same contiguous range.

That said, based on the email discussion with you and Jim, I'll just go
ahead and clean this up and move us over to covering switches rather than
bounds based tests.

-Chandler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130204/091072e7/attachment.html>


More information about the llvm-commits mailing list