[PATCH] [Driver] Add -L and -l support.

Michael Spencer bigcheesegs at gmail.com
Mon Feb 4 16:37:27 PST 2013



================
Comment at: include/lld/Core/LinkerOptions.h:37
@@ -36,2 +36,3 @@
   Object,
+  Library,
   LLVM,
----------------
kledzik at apple.com wrote:
> This file has no comments.  Can you add some to explain the reason for InputKind?  
> 
> Should static and dynamic libraries have a different enum?  
> 
> It sort of looks like "Library" really means "search for it via -L options".  For instance on darwin we link with -lcrt1.o but crt1.o is an object file which happens to be found via library search paths.
Yeah, Library means look up via -L. On Windows we actually have the opposite case where all inputs are looked up via library search paths. We should probably use a different name for this then.

The main reason InputKind exists is to cache the type of file instead of looking it up every time it's needed.


http://llvm-reviews.chandlerc.com/D365



More information about the llvm-commits mailing list