[PATCH] Loop Vectorizer: Refactor code to compute vectorized memory instruction cost

[Arnold Schwaighofer]

No you are not wrong. Fixed in the attached patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Loop-Vectorizer-Refactor-code-to-compute-vectorized-.patch
Type: application/octet-stream
Size: 13083 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130204/3bc9afbe/attachment.obj>
-------------- next part --------------



On Feb 4, 2013, at 1:50 PM, Renato Golin <renato.golin at linaro.org> wrote:

> Hi Arnold,
> 
> I may be wrong, but I think these guys are only ever used internally:
> 
> +    unsigned getOpcode() { return Opcode; }
> +
> +    unsigned getAlignment() { return Alignment; }
> +
> +    unsigned getPointerAddressSpace() { return AddressSpace; }
> +
> +    Value *getPointerOperand() { return PointerOperand; }
> +
> +    Type *getScalarType() { return ScalarTy; }
> +
> +    Type *getVectorType() { return VectorTy; }
> 
> So, they don't need the getters, and you can use them directly in the other members of the MemoryOpCost class.
> 
> cheers,
> --renato