[LLVMdev] [PATCH] parallel loop metadata

Pekka Jääskeläinen pekka.jaaskelainen at tut.fi
Mon Feb 4 01:30:35 PST 2013


Thanks,

I fixed the others. I'll send an updated patch later.

On 02/01/2013 09:38 AM, Tobias Grosser wrote:
> One point I am not entirely sure is: Is the parallel_loop_access
> meta-data somehow connected to the loop.parallel metadata. I think we
> need to also ensure that the parallel_loop_access metadata in a loop
> actually comes from the loop itself and was not introduced in some other
> unrelated way. I don't have a good example where this may happen, but
> could imagine stuff like inlining or licm from inner loops. I believe it
> should not be very difficult to couple the two, no?

Yes, I can see that adding the coupling should add to robustness even
though I do not have an example that breaks things in mind.

I'll try referring to the branch instruction from the metadata that all of
the metadata then again refers to (bidirectional reference from the
branch itself). That should do (if it works), unless you have a better
idea for this.

-- 
Pekka



More information about the llvm-commits mailing list