[llvm] r174259 - Removing ssp and uwtable from the testcase

[Bill Wendling]

On Feb 4, 2013, at 12:41 AM, Chandler Carruth <chandlerc at google.com> wrote:

> On Mon, Feb 4, 2013 at 12:38 AM, Bill Wendling <wendling at apple.com> wrote:
> On Feb 1, 2013, at 5:34 PM, Manman Ren <mren at apple.com> wrote:
> 
> > Author: mren
> > Date: Fri Feb  1 19:34:38 2013
> > New Revision: 174259
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=174259&view=rev
> > Log:
> > Removing ssp and uwtable from the test case
> >
> Can I ask why? :-)
> 
> Eric asked for it in review of the original patch.
> 
Yeah, I read that after I responded. :-(

> FWIW, I tend to agree. I just like test cases to be as minimized as is reasonably possible to reduce the noise when we do something that either changes the test case or worse, changes the IR format without changing any functionality. The less IR left in the test case, the less frequently we have noise from such things.


I tend to agree. But the log message left me wondering if it was being removed because of a problem or something else. Anyway, no worries here.

-bw

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130204/c5753e70/attachment.html>