[PATCH 1/3] Add new keyword externally_initialized to LLVM.

[Michael Gottesman]

On Feb 1, 2013, at 6:58 PM, Sean Silva <silvas at purdue.edu> wrote:

> On Fri, Feb 1, 2013 at 7:53 PM, Michael Gottesman <mgottesman at apple.com> wrote:
>> I will commit this patch and prepare a second patch with the clarification paragraph and post it here.
> 
> I'm not sure what you mean by "clarification paragraph".

I was referring to the second patch you mentioned. Apologies for the confusion.

> 
> The current patch conflates fixing the omission of mentioning the
> default and adding the new keyword and language feature. I would like
> the bug fix (i.e. fixing the omission) be committed separately (and
> before) the change that depends on the bug fix (i.e. adding the new
> keyword).

Ok.

> 
> So I would go ahead and commit the current patch (subject to review
> from e.g. John McCall) but *excluding the new feature*; this is
> essentially fixing the documentation bug. Since after that adding the
> new keyword to the langref is just one sentence (something like "this
> default behavior can be suppressed with ..."), you can probably just
> commit it in the same commit that adds asm reader/writer support to
> avoid potential confusion during the window where asm reader/writer
> support isn't available.

I would prefer to split this patch up into two pieces, the first with the clarification and the second with the new language feature. The words used to describe the language feature are actually John's so he has sort of reviewed it already (sort of a gray area).

I will make sure to commit them in the order you suggested and then move on with my other patches on the list.

How does that sound?

Michael