[llvm] r174078 - RuntimeDyld: Fix errant fallthrough.

[Alexander Kornienko]

There's a -Wimplicit-fallthrough, which caught this. But it requires
introducing annotations throughout the code (about 390 locations, mostly
covered with comment annotations). And this in turn requires Chris'
approval, and he's not super happy about this for some reason.


On Thu, Jan 31, 2013 at 8:53 PM, Benjamin Kramer <benny.kra at gmail.com>wrote:

>
> On 31.01.2013, at 20:46, Jim Grosbach <grosbach at apple.com> wrote:
>
> > Author: grosbach
> > Date: Thu Jan 31 13:46:28 2013
> > New Revision: 174078
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=174078&view=rev
> > Log:
> > RuntimeDyld: Fix errant fallthrough.
>
> Is there really no way to test this code? :(
>
> - Ben
>
> >
> > Modified:
> >    llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp
> >
> > Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp?rev=174078&r1=174077&r2=174078&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp
> (original)
> > +++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.cpp Thu
> Jan 31 13:46:28 2013
> > @@ -96,6 +96,7 @@ bool RuntimeDyldMachO::resolveI386Reloca
> >       *p++ = (uint8_t)(ValueToWrite & 0xff);
> >       ValueToWrite >>= 8;
> >     }
> > +    return false;
> >   }
> >   case macho::RIT_Difference:
> >   case macho::RIT_Generic_LocalDifference:
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151 221
77 957
Google Germany GmbH | Dienerstr. 12 | 80331 München
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130201/0b359491/attachment.html>