Review request: generate DWARF pubnames under a compiler option

[Krzysztof Parzyszek]

On 1/22/2013 6:19 PM, Eric Christopher wrote:
> Hi Krzysztof,
>
> Sorry for the delay, here's the review you wanted :)
>
> +static cl::opt<bool>
> GenerateDwarfPubNamesSection("generate-dwarf-pubnames",
> +     cl::Hidden, cl::ZeroOrMore, cl::init(false),
> +     cl::desc("Generate DWARF pubnames section"));
>
> I'd prefer this be a debug info option and not a TLOF option, also you
> can just check the file static then as well.
>
> Not sure if there's a point in emitting the section in emitDebugPubNames
> (can we make it emitDebugPubnames since we're adding it back?) if
> Globals.size() == 0 either.
>
> +  if (const MCSection *PNS = TLOF.getDwarfPubNamesSection())
> +    emitSectionSym(Asm, PNS);
>
> You'll probably want to just emit the sym if we're emitting the section,
> that said, since we pretty much don't check for any of the other
> sections no need for the check here. (and SwitchSection has an assert in
> it).
>
> If you wouldn't mind fleshing out the pubnames testcase to make sure a
> wider variety of items are emitted into the pubnames section, also
> llvm-dwarfdump needs to parse the section for the testcase.


Hi Eric,

Here's a patch that includes the changes you asked for.  I hope I didn't 
miss anything.  Let me know what you think.

Thanks,
-Krzysztof


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-optionally-generating-pubnames-section-in-DWAR.patch
Type: text/x-patch
Size: 15156 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130201/db59526f/attachment.bin>