PATCH: TableGen: Report an error when defining more than 32 subreg indices

Malul, Elior elior.malul at intel.com
Thu Jan 31 07:02:49 PST 2013


Although I'm hardly the gate-keeper of tblgen,
I think it would be a good idea to add LIT a test that exposes the bug you fix.
Other than that, LGTM. 

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Tom Stellard
Sent: Thursday, January 31, 2013 16:23
To: llvm-commits at cs.uiuc.edu
Subject: PATCH: TableGen: Report an error when defining more than 32 subreg indices

Hi,

The maximum number of sub reg indices is limited to 32 by use of the LaneMask.  TableGen currently assigns all sub reg indices after the first 32 to the same LaneMask, which leads to bugs in the register allocator.  This patch prevents the user from defining more than 32 sub reg indices.

-Tom
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.





More information about the llvm-commits mailing list