[llvm-commits] [zorg] r172885 - /zorg/trunk/zorg/buildbot/builders/ClangBuilder.py

[Chandler Carruth]

On Wed, Jan 30, 2013 at 4:45 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Tue, Jan 22, 2013 at 4:59 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> > clang-x86_64-linux-vg became green.
> > http://lab.llvm.org:8011/builders/clang-x86_64-linux-vg/builds/648
> >
> > David, could you reconstruct test steps to exclude llvm out of valgrind?
>
> To do that I need to solve another problem:
>
> Chandler: how would I run the clang-tools-extra tests in the
> autoconf/make build (for the buildbots) without using the project-wide
> "make check-all" (ideally I'd like to run the clang tests and the
> clang-tools-extra tests together, but not the llvm tests - to get
> valgrind coverage on the former & not the latter). I can't seem to
> find any targets for that. (& just running "make check" from the
> build/tools/clang/tools/extra directory just runs the clang tests, it
> seems)
>

I have no idea.

Sorry, all of the Makefile based stuff escapes me at the moment. I can dig
into the code to answer, but you can probably do that just as easily. =/ It
very well could be completely broken, as most of us who have been hacking
on it have been using cmake, and most of the others have been using
check-all...


>
> - David
>
> >
> > ...Takumi
> >
> > 2013/1/19 Galina Kistanova <gkistanova at gmail.com>:
> >> Done.
> >>
> >> Thanks
> >>
> >> Galina
> >>
> >> On Fri, Jan 18, 2013 at 7:47 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> >> wrote:
> >>>
> >>> Galina, could you reconfigure the llvmlab for this?
> >>> Then, I will begin watching;
> >>> http://lab.llvm.org:8011/builders/clang-x86_64-linux-vg
> >>>
> >>> ...Takumi
> >>>
> >>> 2013/1/19 NAKAMURA Takumi <geek4civic at gmail.com>:
> >>> > Author: chapuni
> >>> > Date: Fri Jan 18 21:39:07 2013
> >>> > New Revision: 172885
> >>> >
> >>> > URL: http://llvm.org/viewvc/llvm-project?rev=172885&view=rev
> >>> > Log:
> >>> > ClangBuilder: Use LIT_ARGS=clangTestArgs, or valgrind would not be
> >>> > enabled.
> >>> >
> >>> > FIXME: Valgrind affects also llvm tests. Is it expected?
> >>> >
> >>> > Modified:
> >>> >     zorg/trunk/zorg/buildbot/builders/ClangBuilder.py
> >>> >
> >>> > Modified: zorg/trunk/zorg/buildbot/builders/ClangBuilder.py
> >>> > URL:
> >>> >
> http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangBuilder.py?rev=172885&r1=172884&r2=172885&view=diff
> >>> >
> >>> >
> ==============================================================================
> >>> > --- zorg/trunk/zorg/buildbot/builders/ClangBuilder.py (original)
> >>> > +++ zorg/trunk/zorg/buildbot/builders/ClangBuilder.py Fri Jan 18
> >>> > 21:39:07 2013
> >>> > @@ -208,7 +208,7 @@
> >>> >                                                workdir=llvm_1_objdir,
> >>> >                                                env=merged_env))
> >>> >
> >>> > -    clangTestArgs = llvmTestArgs = '-v -j %s' % jobs
> >>> > +    clangTestArgs = '-v -j %s' % jobs
> >>> >      if valgrind:
> >>> >          clangTestArgs += ' --vg'
> >>> >          if valgrindLeakCheck:
> >>> > @@ -220,8 +220,7 @@
> >>> >      if test:
> >>> >          f.addStep(LitTestCommand(name='check-all',
> >>> >                                     command=[make, "check-all",
> >>> > "VERBOSE=1",
> >>> > -
> >>> > WithProperties("LIT_ARGS=%s" % llvmTestArgs),
> >>> > -
> >>> > WithProperties("TESTARGS=%s" % clangTestArgs),
> >>> > +
> >>> > WithProperties("LIT_ARGS=%s" % clangTestArgs),
> >>> >
> >>> > WithProperties("EXTRA_TESTDIRS=%s" % extraTestDirs)],
> >>> >                                     description=["checking"],
> >>> >                                     descriptionDone=["checked"],
> >>> > @@ -323,8 +322,7 @@
> >>> >      if test:
> >>> >          f.addStep(LitTestCommand(name='check-all',
> >>> >                                     command=[make, "check-all",
> >>> > "VERBOSE=1",
> >>> > -
> >>> > WithProperties("LIT_ARGS=%s" % llvmTestArgs),
> >>> > -
> >>> > WithProperties("TESTARGS=%s" % clangTestArgs),
> >>> > +
> >>> > WithProperties("LIT_ARGS=%s" % clangTestArgs),
> >>> >
> >>> > WithProperties("EXTRA_TESTDIRS=%s" % extraTestDirs)],
> >>> >                                     description=["checking"],
> >>> >                                     descriptionDone=["checked"],
> >>> >
> >>> >
> >>> > _______________________________________________
> >>> > llvm-commits mailing list
> >>> > llvm-commits at cs.uiuc.edu
> >>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130130/bddd4f38/attachment.html>