[PATCH] fix llvm linker issue with dbg.declare
Manman Ren
mren at apple.com
Wed Jan 30 11:43:26 PST 2013
On Jan 30, 2013, at 11:26 AM, Bill Wendling wrote:
> Hi Manman,
>
> The patch looks okay to me. Please make sure it ran though some of the nightly tests first. Thanks!
Yes, I ran all tests under MultiSource.
Thanks,
Manman
>
> -bw
>
> On Jan 28, 2013, at 3:21 PM, Manman Ren <mren at apple.com> wrote:
>
>>
>> Hello,
>>
>> Given source IR:
>> call void @llvm.dbg.declare(metadata !{i32* %argc.addr}, metadata !14), !dbg !15
>> we used to generate
>> call void @llvm.dbg.declare(metadata !27, metadata !28), !dbg !29
>> !27 = metadata !{null}
>>
>> With this patch, we will generate
>> call void @llvm.dbg.declare(metadata !{i32* %argc.addr}, metadata !27), !dbg !28
>>
>> Looking up %argc.addr in ValueMap will return null. Since %argc.addr is already
>> correctly set up, we can use identity mapping.
>>
>> Please review,
>>
>> Thanks,
>> Manman
>>
>> <linker.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
More information about the llvm-commits
mailing list