[Bug 14664] InstCombine missing canonicalization of sub-and into a select.

[Nadav Rotem]

On Jan 29, 2013, at 11:48 AM, Muhammad Tauqir Ahmad <muhammad.t.ahmad at intel.com> wrote:

> <0002-instcombine-missing-canonicalization-of-sext-and-to-select.patch>

+      if (X->getType()->isIntegerTy(1) ||
+          (X->getType()->isVectorTy() &&
+           X->getType()->getVectorElementType()->isIntegerTy(1))) {


You can use "X->getScalarType()->isIntegerTy(1)". 

+        Value *zero = Constant::getNullValue(Op1->getType());

zero -> Zero. 

Did you run any tests on this commit ?  Its a good idea to run the test-suite locally before committing just to make sure that we don't break anything. 

Thanks,
Nadav