ARM Cast Cost Table

[Renato Golin]

Hi Nadav,

Thanks for the review!

On 29 January 2013 18:46, Nadav Rotem <nrotem at apple.com> wrote:

> The changes to ARMTargetMachine.h are unrelated to the cost model. Lets
> commit them in a separate patch.
>

That's necessary so I can build the TLI via TM->getTargetLowering(), which
would have return a generic TargetLowering object, not an ARM one, without
it.



> The code in ARMTTI::getCastInstrCos looks good.
>
> +                                 ISD, DstTy.getSimpleVT(),
> SrcTy.getSimpleVT());
>
> Did we pass the 80-col ?  I am not sure.
>

By 1 !! ;) Fixing...



In your test cases you execute both LLC and OPT. If you are checking the
> LLC generates the right pattern then this test should be in
> tests/CodeGen/ARM/.  Can you make the tests smaller ?  You can write a
> two-line function in LL that takes the arguments and performs the operation
> on it.
>

I'll use Arnold's snippets...

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130129/72e4e1f7/attachment.html>