[PATCH] [lld][ELF] Make AtomLayout more accessible.

Michael Spencer bigcheesegs at gmail.com
Tue Jan 29 00:57:48 PST 2013



================
Comment at: lib/ReaderWriter/ELF/DefaultELFLayout.h:379-380
@@ -397,1 +378,4 @@
+    // -noinhibit-exec.
+    if (definedAtom->contentType() == DefinedAtom::typeUnknown)
+      return make_error_code(llvm::errc::invalid_argument);
     const StringRef sectionName = getSectionName(
----------------
Shankar Kalpathi Easwaran wrote:
> Is there a need to check this ?
Yes, we can't return an AtomLayout for an undefined symbol.


http://llvm-reviews.chandlerc.com/D340



More information about the llvm-commits mailing list