[llvm] r173769 - Juggled Debug.h from ObjCARC.h to only the including cpp files that

[Timur Iskhodzhanov]

Hi Michael,

I think this has broken the Windows build:

..\..\..\..\llvm\lib\Transforms\ObjCARC\ObjCARCAPElim.cpp(114): error
C2027: use of undefined type 'llvm::raw_ostream'
[llvm-build\lib\Transforms\ObjCARC\LLVMObjCARCOpts.vcxproj]
          include\llvm/ADT/Twine.h(23) : see declaration of 'llvm::raw_ostream'

..\..\..\..\llvm\lib\Transforms\ObjCARC\ObjCARCOpts.cpp(181): error
C2027: use of undefined type 'llvm::raw_ostream'
[llvm-build\lib\Transforms\ObjCARC\LLVMObjCARCOpts.vcxproj]
          include\llvm/ADT/Twine.h(23) : see declaration of 'llvm::raw_ostream'

--
Timur

2013/1/29 Michael Gottesman <mgottesman at apple.com>:
> Author: mgottesman
> Date: Mon Jan 28 22:51:59 2013
> New Revision: 173769
>
> URL: http://llvm.org/viewvc/llvm-project?rev=173769&view=rev
> Log:
> Juggled Debug.h from ObjCARC.h to only the including cpp files that
> actually have DEBUG statements. Also changed raw_ostream in said header
> to be a forward declaration (removing an include).
>
> Modified:
>     llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.h
>     llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp
>     llvm/trunk/lib/Transforms/ObjCARC/ObjCARCContract.cpp
>     llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp
>
> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.h?rev=173769&r1=173768&r2=173769&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.h (original)
> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.h Mon Jan 28 22:51:59 2013
> @@ -30,13 +30,15 @@
>  #include "llvm/IR/Module.h"
>  #include "llvm/Pass.h"
>  #include "llvm/Support/CallSite.h"
> -#include "llvm/Support/Debug.h"
>  #include "llvm/Support/InstIterator.h"
> -#include "llvm/Support/raw_ostream.h"
>  #include "llvm/Transforms/ObjCARC.h"
>  #include "llvm/Transforms/Utils/Local.h"
>
>  namespace llvm {
> +class raw_ostream;
> +}
> +
> +namespace llvm {
>  namespace objcarc {
>
>  /// \brief A handy option to enable/disable all ARC Optimizations.
>
> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp?rev=173769&r1=173768&r2=173769&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp (original)
> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp Mon Jan 28 22:51:59 2013
> @@ -32,6 +32,7 @@
>  #include "ObjCARC.h"
>  #include "llvm/ADT/STLExtras.h"
>  #include "llvm/IR/Constants.h"
> +#include "llvm/Support/Debug.h"
>
>  using namespace llvm;
>  using namespace llvm::objcarc;
>
> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARCContract.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARCContract.cpp?rev=173769&r1=173768&r2=173769&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARCContract.cpp (original)
> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARCContract.cpp Mon Jan 28 22:51:59 2013
> @@ -31,6 +31,7 @@
>  #include "llvm/Analysis/Dominators.h"
>  #include "llvm/IR/InlineAsm.h"
>  #include "llvm/IR/Operator.h"
> +#include "llvm/Support/Debug.h"
>
>  using namespace llvm;
>  using namespace llvm::objcarc;
>
> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp?rev=173769&r1=173768&r2=173769&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp (original)
> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp Mon Jan 28 22:51:59 2013
> @@ -39,6 +39,7 @@
>  #include "llvm/ADT/Statistic.h"
>  #include "llvm/IR/LLVMContext.h"
>  #include "llvm/Support/CFG.h"
> +#include "llvm/Support/Debug.h"
>
>  using namespace llvm;
>  using namespace llvm::objcarc;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



-- 
Timur Iskhodzhanov,
Google Russia